Skip to content

[TASK] Add assertInstanceOf tests for CSSListItem #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[TASK] Add assertInstanceOf tests for CSSListItem #1237

merged 1 commit into from
Apr 9, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 8, 2025

These should probably have been added as part of #1212. They confirm that the various types supplanted by CSSListItem in the API all implement the new interface.

Resolves #1236.

@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Apr 8, 2025
@JakeQZ JakeQZ requested a review from oliverklee April 8, 2025 23:33
@JakeQZ JakeQZ self-assigned this Apr 8, 2025
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 8, 2025

This will have merge conflicts with #1231.

@coveralls
Copy link

coveralls commented Apr 8, 2025 •
edited
Loading

Coverage Status

coverage: 54.382% (+1.1%) from 53.315%
when pulling dea50e5 on task/assertinstanceof-csslistitem
into b74cf2e on main.

@oliverklee
Copy link
Contributor

Looks good. This change now needs a rebase, though.

@JakeQZ
[TASK] Add assertInstanceOf tests for CSSListItem
dea50e5 
These should probably have been added as part of #1212.
They confirm that the various types supplanted by `CSSListItem` in the API all
implement the new interface.

Resolves #1236.
@JakeQZ JakeQZ force-pushed the task/assertinstanceof-csslistitem branch from cb72467 to dea50e5 Compare April 9, 2025 16:25
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 9, 2025

Just needs a final check that conflicts have been resolved correctly, particularly in RuleSetTest.

@JakeQZ JakeQZ requested a review from oliverklee April 9, 2025 16:27
@oliverklee oliverklee merged commit f036005 into main Apr 9, 2025
21 checks passed
@oliverklee oliverklee deleted the task/assertinstanceof-csslistitem branch April 9, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Add assertInstanceOf tests for newly introduced interfaces
3 participants
@JakeQZ @coveralls @oliverklee